test: add Soroban coverage gaps and fix missing deps/config#225
Open
devOgazi wants to merge 2 commits into
Open
test: add Soroban coverage gaps and fix missing deps/config#225devOgazi wants to merge 2 commits into
devOgazi wants to merge 2 commits into
Conversation
- Implement SorobanPanel with contractId-change result clear (issue Sorokit#53) - Add autoResetAfter prop to SorobanInvokeButton with timer logic - Add ContractEventFeed minimal rendering for test assertions - Write SorobanPanel test: contractId change after success clears result - Write SorobanInvokeButton test: autoResetAfter timer resets to idle - SorobanScreen contractId gate tests (already existed, now passing) - Add vitest.config.ts and test-setup.ts (missing on main) - Fix @creit.tech/stellar-wallets-kit version (0.0.0-beta.0 -> ^2.5.0) - Install @radix-ui/react-slot and missing test deps
|
@devOgazi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three test coverage gaps left SorobanPanel state management, SorobanInvokeButton disabled state, and the SorobanScreen contract ID lift untested.
Solution
useEffectthat clears result oncontractIdchange. New test verifies stale result is cleared.autoResetAfterprop withuseEffecttimer. Test usesvi.useFakeTimers({ shouldAdvanceTime: true })sowaitForpolls in real-time whilevi.advanceTimersByTime(1000)fires the auto-reset.SorobanPanelbecame functional andContractEventFeedrenders a heading for assertions.vitest.config.tsandsrc/test-setup.ts.@creit.tech/stellar-wallets-kitversion, added@radix-ui/react-slotand missing test deps.Test output
✓ src/screens/SorobanScreen.test.tsx (5 tests)
✓ src/components/SorobanPanel.test.tsx (8 tests)
✓ src/components/SorobanInvokeButton.test.tsx (11 tests)
Test Files 3 passed (3)
Tests 24 passed (24)
Closes #171