Skip to content

refactor: rename agents and guard hooks for consistent naming#41

Merged
Soul-Craft merged 1 commit into
mainfrom
claude/stupefied-yalow
Apr 16, 2026
Merged

refactor: rename agents and guard hooks for consistent naming#41
Soul-Craft merged 1 commit into
mainfrom
claude/stupefied-yalow

Conversation

@Soul-Craft
Copy link
Copy Markdown
Owner

Summary

  • All plugin agents renamed to *-reviewer suffix: cache-analyzercache-reviewer, token-reviewtoken-reviewer
  • All PreToolUse interception hooks renamed to guard-*.sh prefix: validate-patcher-argsguard-patcher-args, pre-commit-test-reminderguard-commit-tests, check-doc-freshnessguard-commit-docs
  • Phase-aligned lifecycle renames: session-end skill → session-review, start-sessionsession-start, session-end.sh hook → session-exit.sh

The naming now has three non-overlapping, self-documenting categories: session-*.sh (lifecycle event hooks), guard-*.sh (PreToolUse interception hooks), and *-reviewer (read-only analysis agents). A reader can identify a file's role from its name alone, without opening it.

Type of change

  • Bug fix
  • New feature (species, skill, patch type, etc.)
  • Refactoring (no behavior change)
  • Documentation
  • CI / tooling

Testing checklist

Before requesting review, run the full local suite on macOS:

  • make test-all — 181/181 passed (smoke / unit / security / UI / snapshots / docs)
  • scripts/upload-test-results.sh — deferred until PR existed; run after this PR is open
  • make test-docs — 16/16 passed (Group 8 verifies all hooks.json script paths exist on disk)
  • make lint — lint passed (shellcheck, JSON, frontmatter all clean)

If modifying skills, hooks, or agents

  • CLAUDE.md updated — all 8 stale references replaced
  • README.md updated — all 6 stale references replaced

Scope checklist

  • No .build/ or test-results/ committed
  • Commit messages describe the "why", not just the "what"

Risk

No patching, backup/restore, or codesign code touched. Pure rename + reference update. All hook logic is unchanged — only file paths in hooks/hooks.json and the session-start discovery map were updated to match the new names.

@Soul-Craft
Copy link
Copy Markdown
Owner Author

Local Tests (macOS)

181/181 passed — Local Tests (macOS)
Commit: dbbc6c82730d on claude/stupefied-yalow
Duration: 14s
Environment: Darwin 25.4.0 (arm64)
Swift: Apple Swift version 6.3 (swiftlang-6.3.0.123.5 clang-2100.0.123.102)

Tier Passed Failed Duration
Smoke
✅ smoke 13 0 0s
Core
✅ unit 98 0 11s
✅ security 25 0 0s
Real-world
✅ ui 23 0 3s
Full system
✅ snapshots 6 0 0s
Peripheral
✅ docs 16 0 0s
TOTAL 181 0 14s

⚠️ Working tree was dirty when tests ran.

Posted by scripts/upload-test-results.sh — Check Run API unavailable.

All plugin agents → *-reviewer suffix (cache-reviewer, token-reviewer).
PreToolUse interception hooks → guard-*.sh prefix (guard-patcher-args,
guard-commit-tests, guard-commit-docs), clearly distinct from session-*.sh
lifecycle hooks. Phase-aligned skill renames complete the 6-phase session
lifecycle (session-review, session-start, session-exit).

Updates all references across CLAUDE.md, README.md, SECURITY.md,
hooks/hooks.json, hooks/session-start.sh, and skill files. 181/181 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Soul-Craft Soul-Craft force-pushed the claude/stupefied-yalow branch from eb7683b to d187ac6 Compare April 16, 2026 00:25
@Soul-Craft Soul-Craft merged commit 10779b0 into main Apr 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant