refactor: rename agents and guard hooks for consistent naming#41
Merged
Conversation
Owner
Author
Local Tests (macOS)181/181 passed — Local Tests (macOS)
Posted by scripts/upload-test-results.sh — Check Run API unavailable. |
All plugin agents → *-reviewer suffix (cache-reviewer, token-reviewer). PreToolUse interception hooks → guard-*.sh prefix (guard-patcher-args, guard-commit-tests, guard-commit-docs), clearly distinct from session-*.sh lifecycle hooks. Phase-aligned skill renames complete the 6-phase session lifecycle (session-review, session-start, session-exit). Updates all references across CLAUDE.md, README.md, SECURITY.md, hooks/hooks.json, hooks/session-start.sh, and skill files. 181/181 tests pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
eb7683b to
d187ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*-reviewersuffix:cache-analyzer→cache-reviewer,token-review→token-reviewerguard-*.shprefix:validate-patcher-args→guard-patcher-args,pre-commit-test-reminder→guard-commit-tests,check-doc-freshness→guard-commit-docssession-endskill →session-review,start-session→session-start,session-end.shhook →session-exit.shThe naming now has three non-overlapping, self-documenting categories:
session-*.sh(lifecycle event hooks),guard-*.sh(PreToolUse interception hooks), and*-reviewer(read-only analysis agents). A reader can identify a file's role from its name alone, without opening it.Type of change
Testing checklist
Before requesting review, run the full local suite on macOS:
make test-all— 181/181 passed (smoke / unit / security / UI / snapshots / docs)scripts/upload-test-results.sh— deferred until PR existed; run after this PR is openmake test-docs— 16/16 passed (Group 8 verifies all hooks.json script paths exist on disk)make lint— lint passed (shellcheck, JSON, frontmatter all clean)If modifying skills, hooks, or agents
CLAUDE.mdupdated — all 8 stale references replacedREADME.mdupdated — all 6 stale references replacedScope checklist
.build/ortest-results/committedRisk
No patching, backup/restore, or codesign code touched. Pure rename + reference update. All hook logic is unchanged — only file paths in
hooks/hooks.jsonand the session-start discovery map were updated to match the new names.