ports EyeMineMod from 1.20.4 to 1.21.1, updating all necessary APIs #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fixing mixin injection points for compatibility with the new Minecraft version. ### Build System - Updated Architectury Loom from 1.7-SNAPSHOT to 1.9-SNAPSHOT - Updated Gradle from 8.8 to 8.11 (required by Loom 1.9) - Fixed neoforge/build.gradle to use correct resource path `META-INF/neoforge.mods.toml` ### Mixin Update - Updated `turnPlayer()` method signature to `turnPlayer(D)V` - now takes a double parameter for movement time in 1.21 - Added `@Shadow` for the new `turnPlayer(double d)` method - Updated injection to pass calculated movement time: `Blaze3D.getTime() - this.lastHandleMovementTime` - Rewrote `onMove` injection to properly handle the 1.21 MouseHandler changes - Cursor is reset to origin (0, 0) rather than screen center for grabbed mode ### Accessor Updates (MinecraftAccessor.java) - Added `setMissTime(int)` and `getMissTime()` accessors for the `missTime` field which is no longer directly accessible ### API Fixes (ModUtils.java) - Replaced deprecated `chunk.getHighestSectionPosition()` with `world.getMaxBuildHeight()` and `world.getMinBuildHeight()` for block position calculations ## Testing - Verified build completes successfully for both Fabric and NeoForge - Eye tracker input properly controls player look direction - Cursor is properly grabbed/hidden during gameplay - GUI screens still function normally with visible cursor
Collaborator
|
Fantastic, thanks so much! @Mrbysco did you want to review any of this before I merge the PR? |
Collaborator
|
Not really, I just need confirmation it works as intended ;) |
Author
|
It works, Saturday and Eyegazegirl have been using it but when you look down at the onscreen keyboard it doesn't fully stop right now, I plan to fix that once I get some more debug logs from them. I can either do a separate pr for that when I get the info and adjustments for that or we can transitions this to a draft pr until that part is fixed as well. The important features are in and working now though yeah. |
Enhances the gaze-based movement system by pausing movement when the user is looking at the on-screen keyboard area (below a configurable threshold) or outside the game window. This prevents unintended movement when interacting with the keyboard or when gaze tracking is lost. Also, fixes mouse handling in ungrabbed mode to recalculate accumulated values correctly.
Author
|
ok I've had a chance to cleanup the autopausing when your gaze leaves the area now and improved the responsiveness in general. It should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed mixin injection points for compatibility with the new MC version.
Build System
META-INF/neoforge.mods.tomlMixin Update
turnPlayer()method signature toturnPlayer(D)V- now takes a double parameter for movement time in 1.21@Shadowfor the newturnPlayer(double d)methodBlaze3D.getTime() - this.lastHandleMovementTimeonMoveinjection to properly handle the 1.21 MouseHandler changesAccessor Updates (MinecraftAccessor.java)
setMissTime(int)andgetMissTime()accessors for themissTimefield which is no longer directly accessibleAPI Fixes (ModUtils.java)
chunk.getHighestSectionPosition()withworld.getMaxBuildHeight()andworld.getMinBuildHeight()for block position calculationsTesting