Features to support better cooperation with Obsidian#128
Open
mrtati wants to merge 6 commits intoSpenhouet:mainfrom
Open
Features to support better cooperation with Obsidian#128mrtati wants to merge 6 commits intoSpenhouet:mainfrom
mrtati wants to merge 6 commits intoSpenhouet:mainfrom
Conversation
… last changed date
Owner
|
@mrtati Thanks for the PR. Can you rebase this and reintegrate into the current version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For my use case with Obsidian, I have added some features that the community might find useful as well.
These features are:
version.whenvalue), this behavior is unconditional, should avoid unnecessary syncing and should help order files as they were edited on Confluenceexport.page_toc, by default true (so no change to existing functionality while true)export.page_metadata_in_frontmatterwas introduced, by default disabled (no change to existing functionality while false), when enabled the front matter is filled with Confluence page metadata:export.page_always_expandwas added, by default disabled (no change to existing functionality while false), when enabled the expand-container blocks are rendered as normal content without the<details>\n<summary>wrapping.Additionally, there is a correction:
file_id, only anidwhich is taken from a different html tag. Original implementation was kept, this functionality is additional, if the id is not found indata-media-id, it will be checked indata-linked-resource-idas well.Test Plan
Manual testing was done by changing the new config flags and observing the difference in output.