Update to curation format v2 #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
reviewed
Jul 3, 2025
| self.curation_data = curation_data | ||
| # validate the curation data | ||
| format_version = curation_data.get("format_version", None) | ||
| # assume version 2 if not present |
There was a problem hiding this comment.
No I would not do this. This will be a mess with previous curation files.
Lets be strict and accept only dict that do not the format_version, this is part of the spec. no?
There was a problem hiding this comment.
No curation format is needed for validation!
What we can do is try 2 and then 1. Ok?
There was a problem hiding this comment.
Let's add it to the test curation. The controller should fail if not provided
samuelgarcia
reviewed
Jul 3, 2025
| "removed_units": [] | ||
| "merges": [], | ||
| "splits": [], | ||
| "removes": [] |
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.