Proposal: Add analyzer.frame_slice
#4147
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #4133, here is a draft proposal for implementing a
frame_slicemethod for the sorting analyzer, to see how tricky it is.API is:
which matches the
frame_slicemethods for sorting and recording objects.There's a "hard" mode (which just recomputes all extensions) and a "soft" mode (which attempts to estimate the extensions). Almost all the complexity occurs at the level of the extension. For each extension, we'd need to implement a
_frame_slice_extension_datamethod.I've only implemented
_frame_slice_extension_dataforrandom_spikes, and you can only return an in memory analyzer for the moment.Would like some feedback on the basic structure before doing anything more.