null fixes 3

Author: robrbecker

CHANGELOG.md

@@ -72,7 +72,7 @@
 - For web: browser specific helper methods have moved. use import `package:github/browser_helper.dart` (renderMarkdown, and createAvatorImage)
 - `createGithubClient(...)` has been removed. Just create a GitHub object directly now.
 - `findAuthenticationFromEnvironment` now works in both server/flutter and web environments
-  - On the web, it will check the query string first, then localstorage
+  - On the web, it will check the query string first, then session storage
 - all static methods are now factory constructors
 - fromJSON is now fromJson everywhere
 - toJSON is now toJson everywhere

example/index.dart

@@ -4,8 +4,8 @@ import 'common.dart';
 void main() {
   final tokenInput = querySelector('#token') as InputElement;
   tokenInput.value = github.auth!.token ?? '';
-  window.localStorage['GITHUB_TOKEN'] = tokenInput.value!;
+  window.sessionStorage['GITHUB_TOKEN'] = tokenInput.value!;
   tokenInput.onKeyUp.listen((_) {
-    window.localStorage['GITHUB_TOKEN'] = tokenInput.value!;
+    window.sessionStorage['GITHUB_TOKEN'] = tokenInput.value!;
   });
 }

example/repos.dart

@@ -79,7 +79,7 @@ void loadRepos([int Function(Repository a, Repository b)? compare]) {
       ..id = 'title');
   }
 
-  String? user = 'Workiva';
+  String? user = 'SpinlockLabs';
 
   if (queryString.containsKey('user')) {
     user = queryString['user'];
@@ -98,7 +98,4 @@ void loadRepos([int Function(Repository a, Repository b)? compare]) {
     _reposCache = repos;
     updateRepos(repos, compare);
   });
-
-  github.repositories.listTags(RepositorySlug('Workiva','font_face_observer')).toList();
-  github.issues.listByRepo(RepositorySlug('Workiva','over_react')).toList().then((value) => print);
 }

lib/src/browser/xplat_browser.dart

@@ -10,7 +10,7 @@ import 'package:github/src/common/xplat_common.dart'
 Authentication findAuthenticationFromEnvironment() {
   // search the query string parameters first
   var auth = findAuthenticationInMap(_parseQuery(window.location.href));
-  auth ??= findAuthenticationInMap(window.localStorage);
+  auth ??= findAuthenticationInMap(window.sessionStorage);
   return auth ?? Authentication.anonymous();
 }
 

lib/src/common/model/issues.dart

@@ -15,7 +15,7 @@ class Issue {
     this.state = '',
     this.title = '',
     this.user,
-    this.labels = const <IssueLabel>[],
+    List<IssueLabel>? labels,
     this.assignee,
     this.milestone,
     this.commentsCount = 0,
@@ -25,9 +25,14 @@ class Issue {
     this.updatedAt,
     this.body = '',
     this.closedBy,
-  });
+  }) {
+    if (labels != null) {
+      this.labels = labels;
+    }
+  }
 
   /// Issue Labels
+  @JsonKey(defaultValue: <IssueLabel>[])
   List<IssueLabel> labels = <IssueLabel>[];
 
   @JsonKey(defaultValue: 0)