[BugFix] Disable COUNT(*) fast path for duplicate key table with range distribution#69002
Open
srlch wants to merge 4 commits intoStarRocks:mainfrom
Open
[BugFix] Disable COUNT(*) fast path for duplicate key table with range distribution#69002srlch wants to merge 4 commits intoStarRocks:mainfrom
srlch wants to merge 4 commits intoStarRocks:mainfrom
Conversation
…e distribution ## Why I'm doing: For duplicate key table, SELECT COUNT(*) can be accelerated by tablet statistics or meta scan in BE/CN side. But for range distribution table, the row count statistics is not accurate, which may cause the query result to be incorrect. ## What I've done: - Disable COUNT(*) fast path for duplicate key table with range distribution - Add a check in the rule to disable COUNT(*) fast path for duplicate key table with range distribution Signed-off-by: srlch <linzichao@starrocks.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be908d7e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...ain/java/com/starrocks/sql/optimizer/rule/transformation/RewriteSimpleAggToMetaScanRule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: srlch <linzichao@starrocks.com>
Signed-off-by: srlch <linzichao@starrocks.com>
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
For duplicate key table, SELECT COUNT(*) can be accelerated by tablet statistics or meta scan in BE/CN side. But for range distribution table, the row count statistics is not accurate, which may cause the query result to be incorrect.
What I've done:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: