Skip to content

fix: security hardening — externalize API key, harden code sanitizer,…#44

Open
sethoshi18 wants to merge 1 commit into
StartaleGroup:masterfrom
sethoshi18:devin/1779962095-security-fixes
Open

fix: security hardening — externalize API key, harden code sanitizer,…#44
sethoshi18 wants to merge 1 commit into
StartaleGroup:masterfrom
sethoshi18:devin/1779962095-security-fixes

Conversation

@sethoshi18

Copy link
Copy Markdown

… upgrade vulnerable deps

  • Remove hardcoded Amplitude API key from initCCA.ts; read from AMPLITUDE_API_KEY env var with EXAMPLE_TOKEN fallback
  • Harden pay playground code sanitizer:
    • Block globalThis, self, Proxy, Reflect, constructor, proto and other prototype-chain traversal globals
    • Block ThisExpression to prevent scope escape
    • Add DANGEROUS_PROPERTIES check on all member expressions
  • Upgrade vulnerable dependencies:
    • glob ^11.0.0 → ^11.1.0 (command injection fix)
    • next ^14.2.10 → ^14.2.35 (3 DoS CVEs)
    • @isaacs/brace-expansion override >=5.0.1 (ReDoS fix)

Summary

How did you test your changes?

… upgrade vulnerable deps

- Remove hardcoded Amplitude API key from initCCA.ts; read from
  AMPLITUDE_API_KEY env var with EXAMPLE_TOKEN fallback
- Harden pay playground code sanitizer:
  - Block globalThis, self, Proxy, Reflect, constructor, __proto__ and
    other prototype-chain traversal globals
  - Block ThisExpression to prevent scope escape
  - Add DANGEROUS_PROPERTIES check on all member expressions
- Upgrade vulnerable dependencies:
  - glob ^11.0.0 → ^11.1.0 (command injection fix)
  - next ^14.2.10 → ^14.2.35 (3 DoS CVEs)
  - @isaacs/brace-expansion override >=5.0.1 (ReDoS fix)

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant