Skip to content

Implement New Controller for Notebook Culling & Add Tests #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bryanpaget wants to merge 2 commits into
base: stc-master
Choose a base branch
from
Draft

Implement New Controller for Notebook Culling & Add Tests #248

bryanpaget wants to merge 2 commits into from

Conversation

@bryanpaget
Copy link

@bryanpaget bryanpaget commented Apr 1, 2025

Description:

  • Added a new controller to manage notebook culling based on idle state.
  • Ensures that notebooks exceeding the idle threshold are deleted while active ones remain.
  • Integrated logic for setting and checking stop annotations.
  • Implemented unit tests to validate culling behavior, stop annotation logic, and kernel activity checks.

Testing:

  • Ran unit tests to verify proper handling of idle and active notebooks.
  • Confirmed that stop annotations are correctly applied and respected.

Notes:

  • Reviewers, please check if the logic aligns with our expected culling behavior.
  • Open to feedback on test coverage or additional edge cases to consider.

@bryanpaget
feat: improve culling
6cb4ed4 
- Improved error handling
- Optimized API calls (caching & retry logic)
- Single r.Update() per reconcile loop
- Centralized annotation management
- Configurable logging levels
@bryanpaget
feat: improve culling testing
91412a4 
- It properly fetches and processes notebook pods.
- It correctly identifies idle notebooks.
- It accurately logs and handles errors.
- It enforces the culling policy as expected.
@bryanpaget bryanpaget changed the base branch from master to stc-master April 1, 2025 13:48
@bryanpaget bryanpaget changed the title Implemented New Controller for Notebook Culling & Added Tests Implement New Controller for Notebook Culling & Add Tests Apr 1, 2025
@bryanpaget bryanpaget marked this pull request as draft April 1, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanpaget