Feat: Disable plugins #850
Conversation
* implement base frontend changes necessary for plugin disabling * implement frontend diisable functions/ modal --------- Co-authored-by: Jesse Bofill <[email protected]>
…e horizontal focusables
EMERALD0874
left a comment
EMERALD0874
left a comment
There was a problem hiding this comment.
Overall, this seems really good! Have a few minor gripes, but this is awesome work :)
Co-authored-by: EMERALD <[email protected]>
|
Approving workflow for testing :) |
|
@jessebofill the linter is failing; you may want to adjust your formatting in the files which it didn't like. …Incidentally, will update checks still work with the disabled plugins? A major reason to use this functionality (IMO) is to disable plugins broken by a Steam UI update until they support the changes (instead of uninstalling them); and I'd prefer not having to re-enable the plugin manually every day just to check if it had a fix release since. |
You may want to adjust your wording here 🤔 |
Yes, they still get checked for updates while a plugin is disabled. |
if a request hangs this prevent it from blocking other plugin loads. backend diaptch_plugin which calls this for individual plugin load (as opposed to batch) is set to 15s. other callers of importPlugin are not using timeout, same as before.
4 participants
Please tick as appropriate:
Description
This pr implements the ability to disable plugins. Pretty self explanatory.
Resolves issue #350
Discussion relating to implementation can be found here for reference. https://discord.com/channels/960281551428522045/1424643765888352339
Additional changes
importPlugincall. This is to prevent a hung request to load js from blocking other plugins from loading. This bug is discussed in this thread https://discord.com/channels/960281551428522045/1424643765888352339/1425181590522429550