feat: Implement ledger-sync (#407) and memory-sanitization (#408) features#514
Open
vic-Gray wants to merge 1 commit into
Open
feat: Implement ledger-sync (#407) and memory-sanitization (#408) features#514vic-Gray wants to merge 1 commit into
vic-Gray wants to merge 1 commit into
Conversation
- Add src/models.rs with ledger tracking map for minimum 3-block gap enforcement (StellarFlow-Network#407) - Refactor auth.rs signature validation to use zero-allocation array scanning without intermediate Map (StellarFlow-Network#408) - Add LedgerGapNotSatisfied error variant - Update stake_and_register and update_validator_profile to enforce ledger gaps - Add unit tests for ledger gap verification - Add unit tests for zero-allocation multisig validation Closes StellarFlow-Network#407 Closes StellarFlow-Network#408
|
@vic-Gray Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@GBOYEE has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @GBOYEE to this issue. |
Contributor
|
why you go dey send from main broooooooooooooooooooooo Resolve conflicts ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements two security and performance enhancements for the StellarFlow contracts:
Issue #407 - Ledger-Sync: Enforcing Minimum Ledger Gaps Between Node Ingestions
High-frequency automated scripts can flood the network with consecutive price updates within the same ledger window, creating block noise and running up operations costs.
Changes:
Issue #408 - Memory-Sanitization: Zero-Allocation Array Re-indexing for Quorum Verifications
Spawning temporary vectors inside loop structures during multi-sig signature parsing runs up unnecessary memory allocation fees on the Soroban host engine.
Changes:
Tests Added
Closes #407
Closes #408