Remove server/client ID handshake in favor of public-key-based sender ID assignment in stoffelnet#28
Draft
Remove server/client ID handshake in favor of public-key-based sender ID assignment in stoffelnet#28
stoffelnet#28Conversation
… ID assignment in `stoffelnet` - Updated `connect_as_server` and `connect_as_client` to remove the need for explicit ID parameters. - Introduced `assign_sender_ids` to assign sender IDs post connection establishment. - Refactored network and QUIC peer logic to align with `stoffelnet` public key-based ID handling. - Replaced outdated role-based handshake with ALPN-based identity exchange from `stoffelnet`.
|
This repository is currently set to inactive in Gecko Security. To enable automated security scanning for pull requests, please activate it in your Gecko Security dashboard. |
Mikerah
reviewed
Feb 5, 2026
| connections.len() | ||
| ); | ||
|
|
||
| // Assign sender IDs to all connections based on public key ordering. |
Contributor
There was a problem hiding this comment.
Is there not a way to automatically check this when calling this function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.