-
Notifications
You must be signed in to change notification settings - Fork 41
Add scoop functionality to EcoBin classes #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
greg19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, cool to have it, thanks for contributing 🙂
|
Sorry, FreeCAD uses 3.11, I can go with the new notation. |
|
Thanks for the feedback, it's indeed better now. |
|
Hello @Stu142, a kind ping for this PR. |
|
@graelo thanks for the contribution I'll have time to take a look at it this weekend, I've been unable to find time over the summer but things are cooling down now and I have some catching up to do. |
Hi, many thanks for this Addon, I love it. I was just missing the scoop for EcoBins.
This PR extends scoop support to both
EcoBinandCustomEcoBinclasses, bringing feature parity with standard storage bins.Changes
inside_wall_negativeBoth classes now expose
Scoop(boolean) andScoopRadius(length) properties in the UI. Default scoop value set to False for backward compatibilityImplementation
The implementation reuses the existing
make_scoop()function and follows established patterns used by other features like label shelves. ForCustomEcoBin, the scoop is properly cut by the inside wall negative to handle custom shapes correctly.Testing
This addresses the feature gap where scoops were available in standard bins but missing from eco bins.
Here's an EcoBin with a scoop (radius: 12mm)
The underside is unaffected:

It also works for 1x1 EcoBins

and custom EcoBins
