Skip to content

feat(metrics): Added node labels to the upstream k8satrributeprocessor's config and updated integration tests #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Sep 18, 2025
Merged

feat(metrics): Added node labels to the upstream k8satrributeprocessor's config and updated integration tests #3976

merged 38 commits into from
Sep 18, 2025

Conversation

samiura
Copy link
Contributor

@samiura samiura commented Aug 20, 2025

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features
Screenshot 2025-08-20 at 15 58 57 Screenshot 2025-08-20 at 15 59 08

@samiura samiura changed the title making k8sattribute processor default for logs and metrics change(logs and metrics):making k8sattribute processor default for logs and metrics Aug 20, 2025
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch 3 times, most recently from df2e705 to 91e6327 Compare August 20, 2025 23:30
@samiura samiura changed the title change(logs and metrics):making k8sattribute processor default for logs and metrics change(logs and metrics): Making k8sattribute processor default for logs and metrics #3976 Aug 20, 2025
@samiura samiura changed the title change(logs and metrics): Making k8sattribute processor default for logs and metrics #3976 change(logs and metrics): Making k8sattribute processor default for logs and metrics Aug 20, 2025
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch from 91e6327 to 17fc1a7 Compare August 20, 2025 23:36
@samiura samiura changed the title change(logs and metrics): Making k8sattribute processor default for logs and metrics change(logs and metrics): Making upstream processor default for logs and metrics Aug 20, 2025
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch 2 times, most recently from 8015b3e to 0beddbf Compare August 21, 2025 21:37
@samiura samiura changed the title change(logs and metrics): Making upstream processor default for logs and metrics Making upstream processor default for logs and metrics Aug 21, 2025
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch from 0beddbf to d2610dd Compare August 21, 2025 21:41
@samiura samiura marked this pull request as ready for review August 25, 2025 22:50
@samiura samiura requested a review from a team as a code owner August 25, 2025 22:50
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch from d2610dd to feb72c8 Compare August 25, 2025 22:54
@samiura samiura changed the title Making upstream processor default for logs and metrics chore(config): Making upstream processor default for logs and metrics Aug 25, 2025
@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch 9 times, most recently from 7ef8c62 to b88d1f3 Compare August 26, 2025 23:01
rnishtala-sumo
rnishtala-sumo requested changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments around why we probably shouldn't change the default yet and adding a new integration test for ensuring that node labels exist.

@samiura samiura force-pushed the use-k8sattributeprocessor-explicity-by-default branch from b88d1f3 to 4d53128 Compare August 27, 2025 17:47
@samiura samiura changed the title chore(config): Making upstream processor default for logs and metrics chore(config): Added node labels to the upstream k8satrributeprocessor's config and updated integration tests Sep 12, 2025
rnishtala-sumo
rnishtala-sumo reviewed Sep 15, 2025
View reviewed changes
rnishtala-sumo
rnishtala-sumo reviewed Sep 16, 2025
View reviewed changes
@rnishtala-sumo rnishtala-sumo changed the title chore(config): Added node labels to the upstream k8satrributeprocessor's config and updated integration tests feat(metrics): Added node labels to the upstream k8satrributeprocessor's config and updated integration tests Sep 18, 2025
@rnishtala-sumo
Copy link
Contributor

@samiura LGTM! One remaining item is to add a changelog and call this a feature.

arpitasumologic
arpitasumologic reviewed Sep 18, 2025
View reviewed changes
@samiura
Copy link
Contributor Author

samiura commented Sep 18, 2025

@samiura LGTM! One remaining item is to add a changelog and call this a feature.

Added changelog!

rnishtala-sumo
rnishtala-sumo approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@samiura samiura merged commit 81301dd into main Sep 18, 2025
72 checks passed
@samiura samiura deleted the use-k8sattributeprocessor-explicity-by-default branch September 18, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@rnishtala-sumo rnishtala-sumo rnishtala-sumo approved these changes

@chan-tim-sumo chan-tim-sumo Awaiting requested review from chan-tim-sumo

+1 more reviewer

@arpitasumologic arpitasumologic arpitasumologic left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
osc skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samiura @rnishtala-sumo @arpitasumologic @chan-tim-sumo @Astitva-sumo