-
Notifications
You must be signed in to change notification settings - Fork 2
Add startDate and displayNewsletterRegistration fields #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit 5f01a30): https://sunnytechwebsite--pr53-hugogresse-patch-1-f1o429cl.web.app (expires Mon, 19 Jan 2026 13:46:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b96ac7ab85879442bb94dc448b41aeca0f34d16c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds two new fields to ticket objects in the tickets configuration file: startDate to specify when ticket sales begin, and displayNewsletterRegistration to control newsletter registration display.
Changes:
- Added
startDatefield with value "2026-01-27" to both ticket types - Added
displayNewsletterRegistrationboolean field to both ticket types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "soldOut": false, | ||
| "highlighted": false, | ||
| "displayNewsletterRegistration": true, | ||
| "startDate": "2026-01-27", |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace after the comma at the end of this line.
| "available": false, | ||
| "soldOut": false, | ||
| "highlighted": true, | ||
| "startDate": "2026-01-27", |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace after the comma at the end of this line.
| "displayNewsletterRegistration": true, | ||
| "startDate": "2026-01-27", |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field order is inconsistent between ticket objects. In this ticket, displayNewsletterRegistration appears before startDate, but in the second ticket object (lines 24 and 26), startDate appears before displayNewsletterRegistration. Consider maintaining a consistent field order across all ticket objects.
No description provided.