This repository was archived by the owner on Jun 24, 2019. It is now read-only.
Split KSPAPIExtensions into two assemblies#13
Open
toadicus wants to merge 18 commits into
Open
Conversation
… favor of a leaner set of tools focused on fixing Squad's broken tweakables.
… actually changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits KSPAPIExtensions into two assemblies:
KSPAPIExtensions
A stripped-down version of the original, this contains more-or-less only what is required to run the improved tweakables and the elector.
KSPAPIExtras
Everything else from the original: PartMessages, DuckTyping, etc.
In laboratory tests, this implementation can serve as a drop in for at least some users of KSPAPIExtensions. I tested it with TweakableEverything (internal dev version changing "using KSPAPIEL" to "using KSPAPIExtensions" and ProceduralFairings (current live version). The new KSPAPIExtensions wins the election as anticipated, and ProceduralFairings uses the tweakable code from the new version.