Displaying a diff when the assert fails#183
Open
aaronpowell wants to merge 2 commits intoSwissLife-OSS:masterfrom
Open
Displaying a diff when the assert fails#183aaronpowell wants to merge 2 commits intoSwissLife-OSS:masterfrom
aaronpowell wants to merge 2 commits intoSwissLife-OSS:masterfrom
Conversation
Added a dependency on DiffPlex and changed the IAssert implementations so that when they fail, a diff is generated from the expected/actual and then that is used in the output. This makes it easier to see where there are problems between the two snapshots. This addresses SwissLife-OSS#136
Contributor
|
note that https://github.com/VerifyTests/DiffEngine is designed to handle opening diffs for many snapshotting libs |
|
It'd be awesome if this could be part of the library! |
Contributor
|
@mlstubblefield or you could move to https://github.com/VerifyTests/Verify 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Generate a diff between the expected/actual snapshot and displaying that on failure.
Addresses #136