Update ORMTranslatableListener.php (Solves issue #103)#107
Open
markmeson wants to merge 4 commits intoSylius:1.10from
Open
Update ORMTranslatableListener.php (Solves issue #103)#107markmeson wants to merge 4 commits intoSylius:1.10from
markmeson wants to merge 4 commits intoSylius:1.10from
Conversation
Change from loose to strict comparison for $reflection.
Changed NULL to null.
markmeson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running make:entity will cause PHP Fatal error if $reflection is null when evaluating $reflection->isAbstract(). Checking if $reflection is null and avoiding the subsequent evaluation will prevent the error.