fix v3.9 release bugs #1355
Merged
fix v3.9 release bugs #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
requested review from
KrisThielemans,
evgueni-ovtchinnikov and
paskino
KrisThielemans
approved these changes
Nov 3, 2025
Member
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
as far as I'm concerned, I'd be happy with 5e-4 as well, but let's hope this is enough
casperdcl
force-pushed
the
fix-test-tol
branch
from
b4b8817 to
fe86495
Compare
paskino
reviewed
Nov 3, 2025
| '''Checks that gradient with 'out' parameter returns the same as without the 'out' parameter. | ||
| Note: the absolute tolerance of the test was increased from the default 1e-8 to 1e-5. | ||
| Note: the absolute tolerance of the test was increased from the default 0 to 3e-4. |
Contributor
There was a problem hiding this comment.
the default is 1e-8, https://numpy.org/doc/stable/reference/generated/numpy.allclose.html
Member
Author
There was a problem hiding this comment.
wrong function, @paskino, vis. https://numpy.org/doc/stable/reference/generated/numpy.testing.assert_allclose.html
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.