Skip to content

Conversation

@evgueni-ovtchinnikov
Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov commented Dec 15, 2025

Changes in this pull request

Implements an alternative way to create a STIRImageData object from AcquisitionData object suggested by @ashgillman that makes the created image data object compatible with the acquisition data object it is created from.

Testing performed

Related issues

This PR takes over from PR #231.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

@KrisThielemans KrisThielemans self-assigned this Jan 15, 2026
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgueni-ovtchinnikov , please merge master on here for conflicts (probably just in the README). Feel free to squash-merge then (do edit the suggested commit message to remove everything that is irrelevant).

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 7a0f174 into master Jan 19, 2026
6 checks passed
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the id-from-ad-nxny branch January 19, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants