Skip to content

Quick fix for MR data views in the case of numpy version 1.* #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KrisThielemans merged 81 commits into from
Jan 15, 2026
Merged

Quick fix for MR data views in the case of numpy version 1.* #1366

KrisThielemans merged 81 commits into from
Jan 15, 2026

Conversation

@evgueni-ovtchinnikov
Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov commented Jan 12, 2026 •
edited
Loading

Changes in this pull request

Testing performed

Related issues

Fixes #1363

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

evgueni-ovtchinnikov and others added 30 commits June 10, 2025 16:06
@evgueni-ovtchinnikov @casperdcl
add STIRImageData::address, params.size_t_par, ImageData.address
8aacd90
@casperdcl
{Image,Acquisition}Data.{__array_interface__,asarray()}
3dc4d76
@evgueni-ovtchinnikov @casperdcl
debugging & testing
f418d96
@casperdcl
ImageData.asarray(copy=None) numpy-like behaviour
44f9551 
- depends on #1317
@casperdcl
address review comments
abe7601
@evgueni-ovtchinnikov
pulled array-ptr, resolved conflicts
fbf83cc
@evgueni-ovtchinnikov
[ci skip] removed unused storage scheme settings from asarray.py demo
030d2ae
@evgueni-ovtchinnikov
added Python CI tests for asarray method
43612a3
@evgueni-ovtchinnikov
fixed CI tests for asarray (test_img_asarray->asarray4img)
d2fb53f
@evgueni-ovtchinnikov
got rid of docopt to fix CI tests for asarray
61a7089
@casperdcl
fix test args
676b2e8
@casperdcl
debugging
30d39f4
@casperdcl
debugging
4662710
@evgueni-ovtchinnikov
merged origin/array-ptr (fixed CI tests except demos)
9eb6c55
@evgueni-ovtchinnikov
Merge branch 'array-ptr' of https://github.com/SyneRBI/SIRF into arra…
ac459af 
…y-ptr
@evgueni-ovtchinnikov
trying to fix PET_DEMOS_PYTHON
6ac6ad4
@evgueni-ovtchinnikov
started working on array interface for ISMRMRD_Acquisition
b1ed678
@evgueni-ovtchinnikov
corrected the __array_interface__ data type code (f4 -> c8)
34fe063
@evgueni-ovtchinnikov
implemented and tested sirf.Gadgetron.Acquisition.asarray() method
c798ec6
@evgueni-ovtchinnikov
started working on array interface for sirf.Gadgetron.AcquisitionData
3353834
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.AcquisitionDataView
ee5ae5b
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.AcquisitionDataView algebra
27ef332
@evgueni-ovtchinnikov
started working on sirf.Gadgetron.ImageDataView algebra
b4bbdbd
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.ImageDataView
e24ce92
@evgueni-ovtchinnikov
added images algebra performance comparison tests
1c9fc08
@evgueni-ovtchinnikov
merged array-ptr-reg onto array-ptr-mr and resolved conflicts
0ad7a2e
@evgueni-ovtchinnikov
added performance tests for nifti images algebra
ae6685d
@evgueni-ovtchinnikov
added acquisitions algebra performance comparison tests
38739fc
@evgueni-ovtchinnikov
added methods __isub__, norm and dot to ImageDataView
afa5db3
@evgueni-ovtchinnikov
introduced GadgetronDataView base class to avoid algebra methods dupl…
73e5f8d 
…ication
evgueni-ovtchinnikov and others added 22 commits October 9, 2025 17:55
@evgueni-ovtchinnikov
added gadgetron data views failure example
ae475dc
@evgueni-ovtchinnikov
fixed gadgetron data views
d77f39c
@evgueni-ovtchinnikov
attended to Codacy issues
236fa0b
@evgueni-ovtchinnikov
attended to further Codacy issues
e602a5c
@evgueni-ovtchinnikov
added MR data algebra timing script
d3216b3
@evgueni-ovtchinnikov
added demo description and missing --non-interactive option in mr_tim…
e4d7117 
…ings.py
@evgueni-ovtchinnikov
attended to Codacy issues
8a6eb90
@evgueni-ovtchinnikov
attended to Codacy issues
7a5688a
@evgueni-ovtchinnikov
removed some commented-out lines [ci skip]
b681cef
@evgueni-ovtchinnikov
updated CHANGES.md [ci skip]
3f95c33
@evgueni-ovtchinnikov
updated NOTICE.txt [ci skip]
bc2f772
@evgueni-ovtchinnikov
corrected NOTICE.txt [ci skip]
8297728
@evgueni-ovtchinnikov
trying to cover the case of old NumPy
739c2eb
@evgueni-ovtchinnikov
corrected Gadgetron.Image definition (missing inheritance from ArrayC…
83cc562 
…ontainer)
@evgueni-ovtchinnikov
attended to Codacy issues
93a02e5
@casperdcl
tidy old numpy<2 handling
65b598b 
- fixes #1338
@evgueni-ovtchinnikov
small amendments related to old NumPy issue
b68b349
@evgueni-ovtchinnikov
updated files for release 3.9.0 [ci skip]
d95c7bb
@evgueni-ovtchinnikov
Merge branch 'master' of https://github.com/SyneRBI/SIRF
54505e7
@evgueni-ovtchinnikov
Merged branch 'master' of https://github.com/SyneRBI/SIRF
dedf83c
@evgueni-ovtchinnikov
fixed #1363
35647f6
@evgueni-ovtchinnikov
resolved conflicts
69019da
@evgueni-ovtchinnikov evgueni-ovtchinnikov changed the title Try fix the case of numpy version 1.* Quick fix for MR data views in the case of numpy version 1.* Jan 12, 2026
@KrisThielemans KrisThielemans self-assigned this Jan 15, 2026
@KrisThielemans KrisThielemans self-requested a review January 15, 2026 10:21
@KrisThielemans KrisThielemans merged commit 70f6fce into master Jan 15, 2026
@KrisThielemans KrisThielemans deleted the try-fix-numpy1 branch January 15, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

Assignees

@KrisThielemans KrisThielemans

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

numpy 1.* incompatibility for MR

4 participants

@evgueni-ovtchinnikov @KrisThielemans @casperdcl