Added normalize-space to gloss value#721
Conversation
|
These changes required some modifications in the test files. As you can see, now this normalizes the whitespace of gloss in all ODD transformations. I actually think this is a better output in all the places where it happens. However, if we just want to change this in the html guidelines and not as a general rule for gloss, we need to find a different place to do the change. I think this general solution is probably better, but just in case. |
sydb
left a comment
There was a problem hiding this comment.
Looks good to me.
- I examined the 1-line code change, looks good
- I spot-checked a few expected results, seemed fine
- I ran
make test2Pon my machine — all tests pass - I ran
make testin a Docker container on my machine — all tests pass
So I am in favor of merging this ASAR.
|
BTW, @GusRiva , in my little brain the important place to effect this change was in the RELAX NG output, where some tools just report whatever whitespace is there, thus sometimes giving ugly results. |
|
I'm happy to merge this with one reviewer's approval, unless you would prefer to review it first @martinascholger? |
martinascholger
left a comment
There was a problem hiding this comment.
Looks good to me.
- Run
make test make html-webwith dev and gusr_717
Dealing with #717
What I did:
Found the place where the content of gloss was created and normalized the whitespace
How I tested:
Example test:
Change /TEI/P5/Source/Specs/ab.xml (line 5) to:
<gloss versionDate="2005-01-14" xml:lang="en"> anonymous block </gloss>Old output (with dev branch):
New output from this branch: