Allowing optional third coordinate to teidata.point for #2816
#2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydb
approved these changes
Sep 24, 2025
Member
There was a problem hiding this comment.
The change @trishaoconnor has made seems perfectly reasonable, the regex looks correct, and it directly addresses the original request. Thus an approval.
But there are two huge caveats:
- Having thought about it a bit more, I do not think this is the right way to do this. I think we can provide users further, more useful constraint, on the theory that almost no one wants both 2D and 3D points on the same attribute.
- Even if this is the way Council decides to address this feature request, prose describing the datatype, prose discussing how to use it, and examples are all in order.
As for #1 I will plan to submit a PR to demonstrate what I have in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2816 which requested allowing an optional third coordinate to
teidata.point. I've tested the changes locally and it passes tests and I would welcome more eyes on this to check that all is well.It would also be helpful to include a good example of 3d encoding as well in this PR and Jun Ogawa will hopefully be able to supply us with one.