Skip to content

Strengthen daterange integration test with compliant test stream - #175

Merged
Danesz merged 2 commits into
feature/daterange-supportfrom
feature/daterange-compliant-stream-tests
Sep 3, 2026
Merged

Strengthen daterange integration test with compliant test stream#175
Danesz merged 2 commits into
feature/daterange-supportfrom
feature/daterange-compliant-stream-tests

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The previous daterange test stream contained an EXT-X-DATERANGE update tag without START-DATE, which Android and Web parsers reject — leaving duration/endDate null and endTime infinite on those platforms, so the test couldn't assert finite metadata or cue lifecycle events.

Switch daterange_test.dart (and the example app's "Daterange source" button) to the new spec-compliant daterange-test.m3u8 stream and strengthen assertions on the first cue (test-010, active 10s–15s into playback):

  • exact id, cueClass, startDate, endDate, duration (5s), plannedDuration
  • finite endTime with endTime - startTime ≈ 5
  • non-empty scte35Out/scte35In payloads and forwarded X-COM-* custom attributes
  • ENTERCUE and EXITCUE events fire as playback crosses the range (new _pumpUntil polling helper instead of a fixed 10s wait)

Link to Devin session: https://dolby.devinenterprise.com/sessions/9c8aebec43564a36a78d52fa710c8fe5
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/9c8aebec43564a36a78d52fa710c8fe5?variant=devin

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Tested the daterange web support end-to-end on Chrome (Devin session)

Web integration suite (flutter drive + chromedriver 152, CI-mirrored command): ✅ All tests passed, including both daterange cue tests (all metadata assertions for test-010) and the no-hlsDateRange negative test. Note: before commit 3daedcd (daterange track forced from disabledhidden on web) the ENTERCUE/EXITCUE assertions failed — the fix is required.

Example app on Chrome — clicked "Daterange source", console output:

Daterange track added: 6
DateRangeCue added: id=test-010, startDate=2015-07-30 05:36:43.000, endDate=2015-07-30 05:36:48.000, duration=5, class=com.theoplayer.daterange-test, customAttributes={X-COM-THEOPLAYER-TEST-LABEL: cue-010, X-COM-THEOPLAYER-TEST-INDEX: 1.0}
ENTERCUE: id=test-010 at startTime=10
EXITCUE: id=test-010 at endTime=15
ENTERCUE: id=test-020 at startTime=20
EXITCUE: id=test-020 at endTime=25

ADDCUE/ENTERCUE/EXITCUE all fire on web with finite endDate/endTime and duration=5 — the discrepancy seen with the old malformed stream is resolved.

Daterange stream playing on web after cue enter/exit

Source loaded (license dialog is informational on localhost)

Daterange source clicked

@Danesz
Danesz force-pushed the feature/daterange-compliant-stream-tests branch from 3daedcd to 94e8c23 Compare September 3, 2026 12:08
@Danesz
Danesz force-pushed the feature/daterange-compliant-stream-tests branch 2 times, most recently from c938c0e to 81faeaf Compare September 3, 2026 14:59
@Danesz
Danesz marked this pull request as ready for review September 3, 2026 15:00
Base automatically changed from feature/web-cue-listener-fix to feature/daterange-support September 3, 2026 15:01
danieldallos-dolby and others added 2 commits September 3, 2026 17:01
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@Danesz
Danesz force-pushed the feature/daterange-compliant-stream-tests branch from 81faeaf to 439ad67 Compare September 3, 2026 15:01
@Danesz
Danesz merged commit d87c784 into feature/daterange-support Sep 3, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants