Allow configuration of ad load timeout for Google IMA plugin#468
Merged
tvanlaerhoven merged 2 commits intoTHEOplayer:developfrom Jan 9, 2025
Merged
Conversation
Enable setting a custom ad load timeout for the Google IMA plugin via the ad configuration. By default, IMA uses an 8-second timeout if no option is provided, but this can now be adjusted as needed.
tvanlaerhoven
approved these changes
Dec 20, 2024
Member
|
@tch-vidangel Thank you for your contribution! |
Member
|
@tch-vidangel I didn't check in detail yet, but there is a build issue on iOS picked-up by our e2e testing: Please take a look; or otherwise we can check as well. |
tvanlaerhoven
approved these changes
Jan 8, 2025
wvanhaevre
approved these changes
Jan 9, 2025
Collaborator
|
Perhaps also add a changelog entry to the CHANGELOG.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable setting a custom ad load timeout for the Google IMA plugin via the ad configuration. By default, IMA uses an 8-second timeout if no option is provided, but this can now be adjusted as needed.