Skip to content

Allow configuration of ad load timeout for Google IMA plugin#468

Merged
tvanlaerhoven merged 2 commits intoTHEOplayer:developfrom
tch-vidangel:feature/all_configure_ima_ad_timeout
Jan 9, 2025
Merged

Allow configuration of ad load timeout for Google IMA plugin#468
tvanlaerhoven merged 2 commits intoTHEOplayer:developfrom
tch-vidangel:feature/all_configure_ima_ad_timeout

Conversation

@tch-vidangel
Copy link
Contributor

Enable setting a custom ad load timeout for the Google IMA plugin via the ad configuration. By default, IMA uses an 8-second timeout if no option is provided, but this can now be adjusted as needed.

Enable setting a custom ad load timeout for the Google IMA plugin via the ad configuration. By default, IMA uses an 8-second timeout if no option is provided, but this can now be adjusted as needed.
@tvanlaerhoven
Copy link
Member

@tch-vidangel Thank you for your contribution!

@tvanlaerhoven tvanlaerhoven added the enhancement New feature or request label Dec 20, 2024
@tvanlaerhoven tvanlaerhoven self-requested a review December 23, 2024 09:37
@tvanlaerhoven
Copy link
Member

@tch-vidangel I didn't check in detail yet, but there is a build issue on iOS picked-up by our e2e testing:

[react-native-theoplayer-tvOS] Compiling THEOplayerRCTView+Ads.swift
Error: cannot assign value of type 'Int' to type 'TimeInterval' (aka 'Double')
            imaRenderSettings.loadVideoTimeout = adLoadTimeout
                                                 ^~~~~~~~~~~~~

Please take a look; or otherwise we can check as well.

@wvanhaevre
Copy link
Collaborator

Perhaps also add a changelog entry to the CHANGELOG.md

@tvanlaerhoven tvanlaerhoven merged commit c0c0eae into THEOplayer:develop Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants