-
Notifications
You must be signed in to change notification settings - Fork 29
Expose webrtc in TheoLiveSource on iOS/Android #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8e6912f
71b94b0
2e0f288
ff05d1c
5db98c5
266dda0
ef92ca4
4f32e90
d0557a9
9696136
330b53a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,5 @@ | ||||||||
| import { SourceIntegrationId, TypedSource } from 'react-native-theoplayer'; | ||||||||
| import { WebrtcOptions } from './WebrtcOptions'; | ||||||||
|
|
||||||||
| /** | ||||||||
| * Represents a source for the THEOlive integration. | ||||||||
|
|
@@ -21,4 +22,9 @@ export interface TheoLiveSource extends TypedSource { | |||||||
| * The profile identifier is included as a query parameter in the discovery request to obtain a response specific to that profile. | ||||||||
| */ | ||||||||
| profile?: string; | ||||||||
|
|
||||||||
| /** | ||||||||
| * WebRTC configuration for a THEOlive Millicast source. | ||||||||
|
||||||||
| * WebRTC configuration for a THEOlive Millicast source. | |
| * WebRTC configuration for a THEOlive Millicast source. | |
| * @platform ios |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
|
|
||
| /** | ||
| * Webrtc playout delay configuration. | ||
| * | ||
| * This is used to configure the playout delay for a Millicast Source. This hints Webrtc | ||
| * to increase the jitter buffer size. | ||
| * | ||
| * @category THEOlive | ||
| * @remark This is a hint, and factors like network jitter and audio/video sync latency affect the actual delay applied. | ||
| * @public | ||
| */ | ||
| export interface WebrtcPlayoutDelay { | ||
| minimum: number; | ||
| maximum: number; | ||
| } | ||
|
|
||
| /** | ||
| * WebRTC configuration for a THEOlive Millicast source. | ||
| * | ||
| * @category THEOlive | ||
| * @public | ||
| */ | ||
| export interface WebrtcOptions { | ||
| /** | ||
| * Webrtc playout delay configuration for the Webrtc media. | ||
| */ | ||
| playoutDelayMs?: WebrtcPlayoutDelay; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebrtcOptions is a THEOplayerSDK type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is