Add API for intermediate delegable operation#23
Open
LKY-stephen wants to merge 5 commits into
Open
Conversation
5 tasks
|
@nonast @davidrotari19 your assistance (review) is requested. |
f0ce034 to
d823168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrade introduces two changes:
Enable wrapped receipt for transfer and store the receipt struct. This is typically used for a delegator to hold the object onchain (i.e., a user can deposit through an onchain object, which will store the wrapped receipt in the dynamic field, a delegator admin can help refresh (withdrawal, claim, and deposit again) for the user without imposing additional permission). The feature is controlled through a new option key
KEY_SUPPORT_RECEIPT_WRAPER_EXTENSIONthat can only be opened once by the admin cap. This is because once opened, there is no way to force all wrapped receipts to unwrap and become non-transferable.Add 3 methods (do_deposit, do_withdrawal, do_claim) such that PTB can accomplish a more complicated flow in one transaction to save cost and respect atomicity.
Add a configuration to allow stopping loyalty token generation post maturity.
PS: If you have an issue when running the test locally, remove the move.lock file temporary.
PS2: Consistency has been tested through the staking website on devnet