style: Report와 Share 합치기 #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/growto/team-grow-to-client/F89mutrxPV7pyk4Z68gMBwgyBpHf |
small-j
reviewed
Apr 21, 2022
| `; | ||
|
|
||
| export const Wrapper = styled.article` | ||
| export const Wrapper = styled.div``; |
Contributor
There was a problem hiding this comment.
wrapper안에 style코드가 들어가지 않고 그냥 태그를 명시하는 용도로만 사용되었는데 이 부분은 styled component가 아니라 그냥 div로 명시하는건 어떨까요?!
Contributor
There was a problem hiding this comment.
흠 그러게 나도 이런 경우엔 div태그를 그냥 사용하긴 하는데 코드스타일마다 다른 것 같기도하고, , 합의가필요하려나?!
Contributor
There was a problem hiding this comment.
아 그렇긴하네요 스타일로 더 명확한 의미로 표시한것 같기도 하고!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainReport와 MainShare을 합쳐보겠습니다