Skip to content

fix: prevent firing onChange when only value prop changed from outside #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: prevent firing onChange when only value prop changed from outside #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/components/CurrencyTextField/CurrencyTextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,11 @@ export const CurrencyTextField: React.FC<CurrencyTextFieldProps> = ({
precision: precision,
});

onChange?.(dineroValue, values.formattedValue);
if (!dineroValue.equalsTo(internalValue)) {
onChange?.(dineroValue, values.formattedValue);

setInternalValue(dineroValue);
setInternalValue(dineroValue);
}
};

/**
Expand Down
11 changes: 10 additions & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Box, Button, Typography } from '@mui/material';

export const App: React.FC = () => {
const [brutto, setBrutto] = React.useState<Dinero.Dinero>(
Dinero({ amount: 133742, currency: 'EUR', precision: 2 }),
Dinero({ amount: 5000, currency: 'EUR', precision: 2 }),
);

return (
Expand Down Expand Up @@ -38,6 +38,15 @@ export const App: React.FC = () => {
>
50 € hinzufügen
</Button>
<Button
variant="contained"
color="primary"
onClick={() => {
setBrutto(() => Dinero({ amount: 5000, currency: 'EUR' }));
}}
>
Auf 50 € setzen
</Button>
<Typography>Dinero amount: {brutto.getAmount()}</Typography>
</Box>
);
Expand Down
Loading