moved ip config to .env file, added extra hosts for easy url acsess #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now edits to the .env ip adresses will be applied automaticly, and it will be possible to acsess services via their names, ie: https://sonar/
Owner
|
Awesome will test this within the next few days |
Author
|
it is very possible that this is a bit too much, but i made some default configs for the env vars and basic service settings that services can inherit and overwrite, instead of duplicating the settings across the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now edits to the .env ip adresses will be applied automaticly, and it will be possible to acsess services via their names, ie: https://sonar/