Hand in Project 2 My Childhood Pets#29
Open
Aencu90 wants to merge 2 commits into
Open
Conversation
HIPPIEKICK
reviewed
Nov 7, 2022
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Nice work with the flexbox! I really enjoy the background gradient and that you used flex-wrap: wrap. A little tip for images:
- When you have set width and height on images they can get distorted. You can add
object-fit: cover;to the images to prevent that.
Keep up the good work :)
| @@ -0,0 +1,25 @@ | |||
| <!DOCTYPE html> | |||
Comment on lines
+11
to
+17
| <section class="pets"> | ||
| <div class="flex-child jason">Jason <img class="pet-image" src="https://images.pexels.com/photos/544269/pexels-photo-544269.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1" alt="Jason" /></div> | ||
| <div class="flex-child paco">Paco <img src="https://images.pexels.com/photos/162149/dog-black-labrador-black-dog-162149.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1" alt ="Paco" /></div> | ||
| <div class="flex-child garfield">Garfield <img src="https://images.pexels.com/photos/6982643/pexels-photo-6982643.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1" alt="Garfield" /></div> | ||
| <div class="flex-child tiger">Tiger <img src="https://images.pexels.com/photos/617278/pexels-photo-617278.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1" alt="Tiger" /></div> | ||
| <div class="flex-child max">Max <img src="https://images.pexels.com/photos/104373/pexels-photo-104373.jpeg?cs=srgb&dl=pexels-mike-b-104373.jpg&fm=jpg&_gl=1*g3sdv7*_ga*NjE4MzQxMDQ4LjE2NjY0MjMyNDY.*_ga_8JE65Q40S6*MTY2NjQyMzI0Ni4xLjEuMTY2NjQyNDczOC4wLjAuMA.." alt="Max" /> </div> | ||
| <div class="flex-child moritz">Moritz <img src="https://images.pexels.com/photos/372166/pexels-photo-372166.jpeg?cs=srgb&dl=pexels-pixabay-372166.jpg&fm=jpg&_gl=1*14yy15f*_ga*NjE4MzQxMDQ4LjE2NjY0MjMyNDY.*_ga_8JE65Q40S6*MTY2NjQyMzI0Ni4xLjEuMTY2NjQyMzMxOS4wLjAuMA.." alt="Moritz" /> </div></section> |
There was a problem hiding this comment.
This looks a bit messy. Remember to always use correct indentation so that the opening tag and the closing tags end up at the same indentation level. Also - always indent children. Compare this snippet with indentation, it gets much easier to read and nice to look at, right? 😇
<section class="pets">
<div class="flex-child jason">
<p>Jason</p> <!--I added a paragraph tag here-->
<img
class="pet-image"
src="https://images.pexels.com/photos/544269/pexels-photo-544269.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1"
alt="Jason" />
</div>
<div class="flex-child paco">
Paco
<img
src="https://images.pexels.com/photos/162149/dog-black-labrador-black-dog-162149.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1"
alt ="Paco" />
</div>
<div class="flex-child garfield">
Garfield
<img
src="https://images.pexels.com/photos/6982643/pexels-photo-6982643.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1"
alt="Garfield" />
</div>
</section>
Comment on lines
+18
to
+22
| <div class="hamburger"> | ||
| <div></div> | ||
| <div></div> | ||
| <div></div> | ||
| </div> |
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| </header> |
There was a problem hiding this comment.
If this is the closing tag, where is the opening tag? 🤔
Comment on lines
+1
to
+11
| body { | ||
| background: radial-gradient( | ||
| circle at 7.5% 24%, | ||
| rgb(237, 161, 193) 0%, | ||
| rgb(250, 178, 172) 25.5%, | ||
| rgb(190, 228, 210) 62.3%, | ||
| rgb(215, 248, 247) 93.8% | ||
| ); | ||
| font-family: "Gill Sans", "Gill Sans MT", Calibri, "Trebuchet MS", sans-serif; | ||
| font-size: 20px; | ||
| } |
There was a problem hiding this comment.
Looking good! If you add min-height: 100vh; you will get rid of the line
Comment on lines
+18
to
+25
| .pets { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| flex-direction: row; | ||
| flex-wrap: wrap; | ||
|
|
||
| } |
Comment on lines
+26
to
+49
| .flex-child { | ||
| margin: 5px; | ||
| width: 200px; | ||
| border: solid black; | ||
| gap: 5px; | ||
| } | ||
| .jason { | ||
| background-color: burlywood; | ||
| } | ||
| .paco { | ||
| background-color: aquamarine; | ||
| } | ||
| .garfield { | ||
| background-color: blueviolet; | ||
| } | ||
| .tiger { | ||
| background-color: blue; | ||
| } | ||
| .max { | ||
| background-color: darkorange; | ||
| } | ||
| .moritz { | ||
| background-color: palevioletred; | ||
| } |
There was a problem hiding this comment.
Really great way of keeping it DRY! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.