Kimberly Project 2#32
Open
Kiimby3 wants to merge 1 commit into
Open
Conversation
HIPPIEKICK
reviewed
Nov 24, 2023
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job with your page! Maybe you want to comment back in the styling for the big about-image? Keep up the good work! /Matilda
Comment on lines
+11
to
+15
| <ul class="navigation-list"> | ||
| <li><a href="articles.html">Articles</a></li> | ||
| <li><a href="about.asp">About</a></li> | ||
| <li><a href="contact.asp">Contact</a></li> | ||
| </ul> |
There was a problem hiding this comment.
Instead of ul, you could use the nav element here
| <main class=""> | ||
| <!-- The main container to use as the flex parent for your card layout, the main content of the site should be in here. --> | ||
| </main> | ||
| <img src="images/comics.jpg" alt="Comic books" class="top-image" /> |
|
|
||
| <div class="about-container"> | ||
| <h1>About</h1> | ||
| <img src="images/shop.jpg" alt="Shop" class="about-image" /> |
There was a problem hiding this comment.
This image is veeery big, maybe style it smaller? It's causing a major side scroll to your page 😅
Comment on lines
+87
to
+94
| /* | ||
| .about-image { | ||
| max-width: 50%; | ||
| max-height: 300px; | ||
| float: left; | ||
| object-fit: cover; | ||
| } | ||
| */ |
There was a problem hiding this comment.
Aah, I see you commented this out 👀
Comment on lines
+8
to
+18
| .navigation-list { | ||
| float: right; | ||
| list-style-type: none; | ||
| margin: 0; | ||
| padding: 0; | ||
| overflow: auto; | ||
| background-color: #f0bbcd; | ||
| position: fixed; | ||
| top: 0; | ||
| width: 100%; | ||
| } |
Comment on lines
+56
to
+67
| .article-container { | ||
| max-width: 66%; | ||
| margin: auto; | ||
| display: flex; | ||
| align-items: center; | ||
| align-content: center; | ||
| flex-direction: row; | ||
| flex-wrap: wrap; | ||
| justify-content: space-between; | ||
| padding: 40px; | ||
| background-color: #f0bbcd; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.