fix(agent): stage sandbox attachments and expose file tools - #2856
Open
nullptr-error wants to merge 2 commits into
Open
fix(agent): stage sandbox attachments and expose file tools#2856nullptr-error wants to merge 2 commits into
nullptr-error wants to merge 2 commits into
Conversation
added 2 commits
August 28, 2026 17:01
…rom the temporary document MessageAttachment.URL is json:"-" so it never survives DB serialization, but stageSessionAttachments depended on it to read the source file, which silently dropped every attachment before it could be written into /workspace/input. Resolve the storage handle from the temporary_documents row keyed by attachment.ID (GetScoped) when the URL is missing, and pass the session tenant through staging so shared-agent sessions look up the right row.
shell_exec was gated on "skills enabled AND a ready skill exists", so an agent whose skills were still installing (or had none) never received a shell. Since shell_exec can execute skill scripts, it now follows the SkillsEnabled switch alone. list_sandbox_files / read_sandbox_file are pure filesystem capabilities and no longer follow SkillsEnabled at all: they are registered whenever the sandbox advertises a SessionFileStore, including for the installer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go test ./internal/application/service -run 'Test(StageSessionAttachments|BuildSandboxAttachmentsPrompt|CreateAgentEngine)'go test ./internal/application/servicecurrently fails locally inTestSkillPythonVerifier/a_pyproject.toml_dependency_the_venv_does_not_carry; this appears unrelated to this branch because the focused tests for the changed areas pass.