fix(wiki): skip ambiguous single-Han auto-links - #2860
Open
JYao-Chen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wiki auto-linking currently treats a one-character Han page title as a safe substring match. Chinese prose has no whitespace token boundary, so a page such as
风can be injected inside风沙, and目inside栏目, splitting normal words into incorrect links.This change skips automatic cross-link injection when the surface form is exactly one Han character. It does not remove one-character Wiki pages and it preserves explicit
[[slug|label]]links produced by the generator or author.Regression tests cover both the false-positive substring and explicit-link preservation.
Type of Change
Related Issue
N/A
Testing
go test ./internal/application/service -run 'TestLinkifyContent|TestFindFirstSafeMatch|TestComputeForbiddenSpans' -count=1go vet ./internal/application/servicegit diff --check origin/main...HEADChecklist
git diff --check origin/main...HEADpassesScreenshots / Recordings
N/A