http_proxy and sslmode support#2
Merged
MT255026 merged 4 commits intorelease-branch-0.0.2from Feb 28, 2025
Merged
Conversation
sc250072
reviewed
Feb 25, 2025
| if self.proxy_bypass_hosts is not None: | ||
| connection_params["proxy_bypass_hosts"] = self.proxy_bypass_hosts | ||
| if self.sslmode is not None: | ||
| connection_params["sslmode"] = self.sslmode |
Collaborator
There was a problem hiding this comment.
Mohan if you are specifying sslmode, there are two options verify-ca and verify-full. These requires ca file. for reference, please check https://github.com/Teradata/airflow/blob/d74dd4112ffb76b706b73f608305ef50fb16d7df/providers/teradata/src/airflow/providers/teradata/hooks/teradata.py#L177
sc250072
requested changes
Feb 25, 2025
| "browser", | ||
| "browser_tab_timeout", | ||
| "browser_timeout", | ||
| "http_proxy", |
Collaborator
There was a problem hiding this comment.
Are there no unit tests for these changes?
MT255026
commented
Feb 25, 2025
Comment on lines
+136
to
+151
| if self.sslca is not None: | ||
| connection_params["sslca"] = self.sslca | ||
| if self.sslcapath is not None: | ||
| connection_params["sslcapath"] = self.sslcapath | ||
| if self.sslcrc is not None: | ||
| connection_params["sslcrc"] = self.sslcrc | ||
| if self.sslcipher is not None: | ||
| connection_params["sslcipher"] = self.sslcipher | ||
| if self.sslprotocol is not None: | ||
| connection_params["sslprotocol"] = self.sslprotocol | ||
| if self.slcrl is not None: | ||
| connection_params["slcrl"] = str(self.slcrl) | ||
| if self.sslocsp is not None: | ||
| connection_params["sslocsp"] = str(self.sslocsp) | ||
| if self.oidc_sslmode is not None: | ||
| connection_params["oidc_sslmode"] = self.oidc_sslmode |
Collaborator
Author
There was a problem hiding this comment.
Yes, those are added here
sc250072
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_proxy and sslmode support