Skip to content

docs(roadmap): mark Wave 1 shipped + capture interim work + version decision#121

Merged
TexasCoding merged 1 commit into
mainfrom
docs/v1.2-wave-1-shipped
May 17, 2026
Merged

docs(roadmap): mark Wave 1 shipped + capture interim work + version decision#121
TexasCoding merged 1 commit into
mainfrom
docs/v1.2-wave-1-shipped

Conversation

@TexasCoding

Copy link
Copy Markdown
Owner

Summary

Post-Wave-1 roadmap update:

Test plan

  • Docs-only change, no code touched

…ecision

- Wave 1: 5 PRs merged 2026-05-17 closing 10 issues. Listed each PR
  with its scope so the table is self-contained without cross-referencing
  GitHub.
- Captured 4 Wave 1 learnings worth carrying forward (bot iterates,
  Order.type rename triggers v1.2-vs-v2.0 decision, worktree CWD slips,
  pip-audit needs pip seeded into uv venv).
- Wave 2 marked ⏸ paused pending interim work. Added an "Interim work"
  section as a placeholder for items to scope.
- Captured follow-ups opened during Wave 1 review (#114 audit, #113
  closed-as-superseded).
- Release-cut criteria: replaced static "HIGH severity items" list with
  ✅/⏳ progress markers, and added an explicit v1.2.0 vs v2.0.0
  decision block driven by #112's Order.type rename.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@TexasCoding TexasCoding merged commit 61cce1c into main May 17, 2026
4 checks passed
@TexasCoding TexasCoding deleted the docs/v1.2-wave-1-shipped branch May 17, 2026 12:36
@claude

claude Bot commented May 17, 2026

Copy link
Copy Markdown

Code Review — PR #121

Status: Merged | Docs-only change to ROADMAP.md


Overview

Post-Wave-1 housekeeping update: converts the Wave 1 plan table to an actuals table, captures learnings, introduces an "Interim work" buffer section, and rewrites the release-cut criteria with the v1.2.0 vs v2.0.0 decision block triggered by the Order.type → Order.order_type rename in #112.


What's Good

  • Actuals table is well-formed. Swapping branch names for merged PR numbers with issue links makes auditing history straightforward. The ⚠️ Breaking callout on fix: Order.type rename, BASE_URL validation, Retry-After NaN/negative guard #112 is exactly the right prominence.
  • Learnings section is concrete. The four bullet points are specific operational observations (bot review iteration count, worktree CWD slippage, pip-audit venv seeding) — far more useful than vague retrospectives.
  • Version-decision block is honest. Laying out both options with their tradeoffs at tag time rather than picking prematurely is the right call. The risk sentence on v1.2.0 (AttributeError with no deprecation period on semver-strict ^1.x pins) is the key fact a future reviewer needs.
  • Progress markers on release criteria (/) make the checklist scannable without opening every linked issue.

Suggestions / Nits

  1. "Interim work" section is empty. A TBD placeholder is fine for living docs, but if there's already at least one scoped item at merge time it would be worth seeding it now. Empty sections can get skipped in future updates. Low priority.

  2. Wave 2 table still uses branch names, not PR numbers. Once Wave 2 lands, consider following the same convention used for Wave 1 (PR links + "Closes" column). Consistency helps future readers understand which items are planned vs. shipped without needing to decode branch naming conventions.

  3. No decision owner or deadline on v1.2.0 vs v2.0.0. The block correctly defers to tag time, but it might be worth adding a one-liner like "Decide before tagging; default to v2.0.0 unless blast-radius analysis at that point shows zero downstream Order.type attribute usage." Right now the text describes the tradeoff but doesn't give a tiebreaker heuristic, which leaves the decision fully open-ended.

  4. #113 closed-as-superseded note — helpful, but the ROADMAP.md doesn't link to what superseded it (security(spec-sync): harden against upstream compromise #109's pattern). The current text says "closed as superseded by security(spec-sync): harden against upstream compromise #109's per-drift fingerprint pattern" which is clear enough, but a reader unfamiliar with security(spec-sync): harden against upstream compromise #109 may lose context. Minor.


Correctness

No factual errors spotted. PR/issue links were spot-checked and match the referenced work. The claim that Wave 1 closed 10 issues across 5 PRs is consistent with the table (2+1+1+3+3 = 10). The CI hotfix (#120) is correctly excluded from the issue-close count.


Summary

Clean, accurate housekeeping. The version-decision block is the most consequential addition and is well-reasoned. Suggestions above are all minor polish; none block anything. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant