fix: make consensusProof.finalizedSlot optional (informational metadata) - #148
Merged
Conversation
…mational `finalizedSlot` is populated during evidence generation (beacon API fetch) but never consumed by the desktop verifier — Helios validates the finality update internally and only extracts the EVM execution state root and block number. Making it optional aligns the schema contract with the actual verification boundary. Also adds `.int()` constraint consistent with the recent integer-schema hardening batch. Closes #135 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consensusProof.finalizedSlotoptional in the beacon schema (z.number().int().optional()) — it is populated during generation but never consumed by the desktop verifier.int()constraint consistent with the recent integer-schema hardening batchContext
Issue #135 identified a trust-boundary contract mismatch:
finalizedSlotwas schema-required (suggesting it's meaningful verification input), but the RustConsensusProofInputstruct doesn't include it and Helios validates the finality update internally — only extracting the EVM execution state root and block number.Making it optional aligns the schema with the actual verification boundary. Existing packages that include
finalizedSlotstill validate; new packages can omit it.Test plan
finalizedSlot: <number>still validate (backwards compatible)Closes #135
🤖 Generated with Claude Code
Note
Low Risk
Schema loosening for a field not consumed by verification; main risk is minor compatibility/validation behavior change for producers/consumers expecting it to be required.
Overview
Aligns the evidence package schema with the desktop verification boundary by making
consensusProof.finalizedSlotoptional and explicitly informational only in the beacon consensus proof schema (nowz.number().int().optional()).Updates
AUDIT.mdto mark issue #135 as closed, reflecting the schema/documentation correction.Written by Cursor Bugbot for commit c6b8d00. This will update automatically on new commits. Configure here.