Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/desktop/src/screens/VerifyScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -830,8 +830,8 @@ function ExecutionSafetyPanel({
[decodedEvents, evidence.simulation?.stateDiffs],
);
const stateDiffSummary = useMemo(
() => summarizeStateDiffs(evidence.simulation?.stateDiffs, decodedEvents, evidence.safeAddress),
[evidence.simulation?.stateDiffs, decodedEvents, evidence.safeAddress],
() => summarizeStateDiffs(evidence.simulation?.stateDiffs, decodedEvents, evidence.safeAddress, evidence.chainId),
[evidence.simulation?.stateDiffs, decodedEvents, evidence.safeAddress, evidence.chainId],
);

const simulationAvailable = Boolean(evidence.simulation);
Expand Down
4 changes: 2 additions & 2 deletions apps/generator/app/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ function EvidenceDisplay({
[allEvents, sim?.stateDiffs],
);
const stateDiffSummary = useMemo(
() => summarizeStateDiffs(sim?.stateDiffs, allEvents, evidence.safeAddress),
[sim?.stateDiffs, allEvents, evidence.safeAddress],
() => summarizeStateDiffs(sim?.stateDiffs, allEvents, evidence.safeAddress, evidence.chainId),
[sim?.stateDiffs, allEvents, evidence.safeAddress, evidence.chainId],
);

return (
Expand Down
46 changes: 46 additions & 0 deletions packages/core/src/lib/simulation/__tests__/summary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,52 @@ describe("summarizeStateDiffs", () => {
expect(result.contracts[1]!.slotsChanged).toBe(2);
expect(result.contracts[2]!.slotsChanged).toBe(1);
});

it("resolves silent contract symbols from well-known registry when chainId is provided", () => {
// USDC on mainnet has state diffs but no events (e.g. allowance consumed via transferFrom)
const diffs: StateDiffEntry[] = [
{ address: TOKEN_B, key: SLOT_1, before: ZERO, after: ONE },
];

const result = summarizeStateDiffs(diffs, [], SAFE, 1);

expect(result.contracts[0]!.tokenSymbol).toBe("USDC");
expect(result.contracts[0]!.hasEvents).toBe(false);
});

it("resolves multi-chain token symbols for silent contracts", () => {
// Polygon USDC (different address from mainnet)
const polygonUSDC = "0x3c499c542cef5e3811e1192ce70d8cc03d5c3359";
const diffs: StateDiffEntry[] = [
{ address: polygonUSDC, key: SLOT_1, before: ZERO, after: ONE },
];

const result = summarizeStateDiffs(diffs, [], undefined, 137);

expect(result.contracts[0]!.tokenSymbol).toBe("USDC");
});

it("prefers event-derived symbol over well-known registry", () => {
const diffs: StateDiffEntry[] = [
{ address: TOKEN_A, key: SLOT_1, before: ZERO, after: ONE },
];
// Event provides symbol "DAI" directly
const events = [makeEvent(TOKEN_A, "transfer", "DAI")];

const result = summarizeStateDiffs(diffs, events, undefined, 1);

expect(result.contracts[0]!.tokenSymbol).toBe("DAI");
});

it("returns null symbol for unknown contract even with chainId", () => {
const diffs: StateDiffEntry[] = [
{ address: RANDOM_CONTRACT, key: SLOT_1, before: ZERO, after: ONE },
];

const result = summarizeStateDiffs(diffs, [], undefined, 1);

expect(result.contracts[0]!.tokenSymbol).toBeNull();
});
});

// ── computeProvenBalanceChanges ─────────────────────────────────────
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/lib/simulation/event-decoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import type { SimulationLog, NativeTransfer } from "../types";
import { formatTokenAmount } from "./format";
import { resolveTokenMeta } from "../tokens/well-known";
import type { TokenMeta } from "../tokens/well-known";

// ── Event signatures (keccak256 hashes) ──────────────────────────────

Expand Down
6 changes: 5 additions & 1 deletion packages/core/src/lib/simulation/summary.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { SimulationLog, NativeTransfer, StateDiffEntry } from "../types";
import { decodeSimulationEvents, decodeNativeTransfers, type DecodedEvent } from "./event-decoder";
import { decodeERC20StateDiffs, type ProvenAllowance, type ProvenBalanceChange, type SlotDecoderResult } from "./slot-decoder";
import { resolveTokenMeta } from "../tokens/well-known";

export type SimulationTransferPreview = {
direction: "send" | "receive" | "internal";
Expand Down Expand Up @@ -282,6 +283,7 @@ export function summarizeStateDiffs(
stateDiffs: StateDiffEntry[] | undefined,
events: DecodedEvent[],
safeAddress?: string,
chainId?: number,
): StateDiffSummary {
if (!stateDiffs || stateDiffs.length === 0) {
return {
Expand Down Expand Up @@ -320,7 +322,9 @@ export function summarizeStateDiffs(
for (const [address, slotsChanged] of byContract) {
contracts.push({
address,
tokenSymbol: tokenSymbols.get(address) ?? null,
tokenSymbol: tokenSymbols.get(address)
?? resolveTokenMeta(address, chainId)?.symbol
?? null,
slotsChanged,
hasEvents: eventContracts.has(address),
});
Expand Down