Skip to content

Allow -inf scores in ROC#41

Merged
ego-thales merged 5 commits intodevelopfrom
19/neginf-scores
Nov 25, 2025
Merged

Allow -inf scores in ROC#41
ego-thales merged 5 commits intodevelopfrom
19/neginf-scores

Conversation

@ego-thales
Copy link
Copy Markdown
Collaborator

@ego-thales ego-thales commented Nov 24, 2025

Update code, docs and tests accordingly.

Decided in favor of adding $(0, 0)$ when necessary because of $-\infty$ score on negative sample. Correspond to the trivial "False" classifier and associated thresholds are [-inf, -inf[, with explanation in ROC.thresholds.

Closes #19.

Signed-off-by: Élie Goudout <elie.goudout@thalesgroup.com>
Signed-off-by: Élie Goudout <elie.goudout@thalesgroup.com>
Signed-off-by: Élie Goudout <elie.goudout@thalesgroup.com>
Signed-off-by: Élie Goudout <elie.goudout@thalesgroup.com>
Signed-off-by: Élie Goudout <elie.goudout@thalesgroup.com>
@ego-thales ego-thales marked this pull request as ready for review November 25, 2025 12:15
@ego-thales ego-thales merged commit 455b0ef into develop Nov 25, 2025
7 of 8 checks passed
@ego-thales ego-thales deleted the 19/neginf-scores branch November 25, 2025 12:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9fff016) to head (b6f6653).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         3723      3723           
=========================================
  Hits          3723      3723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Allow -inf scores in scio.eval.ROC

1 participant