Fix CI on Windows #568
Draft
Fix CI on Windows #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
A-Build-System
|
Looks like we're hitting rust-lang/rust#99466. Since we don't run built scripts, the |
Powershell doesn't have a fail-fast mechanism like Bash, so when the first `cargo test` fails it isn't caught by CI on Windows. This is why the UI tests have failed on Windows for months even though CI was green. https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#exit-codes-and-error-action-preference
Using `&'a Path` causes deserialization to fail on Windows because the path contains backslashes. See <https://bd103.github.io/blog/2025-09-01-zero-copying-strings-serde> for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spun out from #542.
This PR is a multi-part fix to our CI and UI tests on Windows. I believe UI testing has been broken on Windows ever since I introduced it.
Why wasn't this caught earlier
Our CI was incorrectly reporting success even though tests were failing because Powershell, the default scripting language on Windows, doesn't fail-fast on an error.
We were running the tests and doc tests commands in the same CI step. Because the main
cargo testcommand was not the final command run in that step, if it failed the job would still continue. As long as the doc tests passed, CI would be green.In 436e8e2 I fixed this by splitting the commands into two separate steps. The alternative solution would be to switch the scripting language from Powershell to Bash.
TODO :)