Skip to content

Support null -> None conversions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Support null -> None conversions #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ParserState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export type ParserState = {
export const createNewParserState = (typechecker: ts.TypeChecker, config: Ts2PyConfig): ParserState => {
const knownTypes = new Map<ts.Type, string>();
knownTypes.set(typechecker.getVoidType(), "None");
knownTypes.set(typechecker.getNullType(), "None");
knownTypes.set(typechecker.getUndefinedType(), "None");
knownTypes.set(typechecker.getStringType(), "str");
knownTypes.set(typechecker.getBooleanType(), "bool");
Expand Down
1 change: 1 addition & 0 deletions src/testing/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ describe("transpiling basic types", () => {
["export type T = string;", "T = str"],
["export type T = undefined;", "T = None"],
["export type T = void;", "T = None"],
["export type T = null;", "T = None"],
[
"export type T = true;",
"from typing_extensions import Literal\n\nT = Literal[True]",
Expand Down
Loading