feat: support non-hidden sgptrc config file in .config/shell_gpt#766
Open
mariano-soto wants to merge 1 commit intoTheR1D:mainfrom
Open
feat: support non-hidden sgptrc config file in .config/shell_gpt#766mariano-soto wants to merge 1 commit intoTheR1D:mainfrom
mariano-soto wants to merge 1 commit intoTheR1D:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for a non-hidden configuration file
sgptrcinside.config/shell_gpt/, as requested in #751, in addition to the existing.sgptrc.Motivation
Currently, ShellGPT reads configuration from
.config/shell_gpt/.sgptrc. While functional, using a hidden file inside an already hidden directory (.config) feels redundant and slightly unintuitive.Supporting
sgptrcaligns better with common conventions in.configdirectories and improves developer experience.Changes
.config/shell_gpt/sgptrcBehavior
Configuration file resolution now follows this priority order:
.config/shell_gpt/sgptrc.config/shell_gpt/.sgptrc(fallback)Testing
Added tests to verify:
sgptrcis used when present.sgptrcis used whensgptrcis absentAll tests pass and linters succeed.
Backward Compatibility
This change is fully backward compatible. Existing users relying on
.sgptrcwill continue to work without modification.Future Improvements (optional)
.sgptrcis usedCloses #751