Skip to content

Conversation

@edwh
Copy link
Collaborator

@edwh edwh commented Jul 8, 2025

We are moving to use Docker Compose for our dev environment. This PR switches our CircleCI automated testing to use that environment too.

Also includes some fixes to add some required PHP extensions and directories for image uploads.

@edwh edwh self-assigned this Jul 8, 2025
name: Setup application
command: |
# Grant timezone access - run directly on MySQL container
docker exec restarters_db mysql -u root -ps3cr3t -e "GRANT SELECT ON mysql.time_zone_name TO 'restarters'@'%';"

Check failure

Code scanning / SonarCloud

MySQL database passwords should not be disclosed High

Make sure this MySQL database password gets changed and removed from the code. See more on SonarQube Cloud
# Setup additional configuration needed for CI (most setup already done by docker_run.sh)
# Set MySQL function creators using session variable (compatible with MySQL 5.7)
docker exec restarters_db mysql -u root -ps3cr3t -e "SET GLOBAL log_bin_trust_function_creators = 1;"

Check failure

Code scanning / SonarCloud

MySQL database passwords should not be disclosed High

Make sure this MySQL database password gets changed and removed from the code. See more on SonarQube Cloud
echo "Waiting for services in profile: {{.PROFILE}}"
echo ""
# Wait for core services (always needed)

Check failure

Code scanning / SonarCloud

MySQL database passwords should not be disclosed High

Make sure this MySQL database password gets changed and removed from the code. See more on SonarQube Cloud
@edwh edwh requested a review from restart-neil August 4, 2025 08:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping these triggers? I want these repair status strings available in various reporting environments, so would prefer them to remain in the live DB.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're no longer used on the client, and single source of truth is better than triggers. But if you use them elsewhere, then ok - I've removed the migration.

# Conflicts:
#	.circleci/config.yml
#	CLAUDE.md
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants