-
Notifications
You must be signed in to change notification settings - Fork 15
add projects to the backend #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joelamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission @pheobeayo !
Overall looks great 👌
But before I dig deeper I see that there are two things missing: a test file like backend/tests/profile_tests.rs that would greatly improve testing the PR and also a migration file like backend/migrations/001_initial_schema.sql in order to add projects to the database.
Thanks in advance
Okay, I am working on it |
|
@pheobeayo Thanks for your work. |
|
Hey @pheobeayo , happy new year! |
Yes, it is |
joelamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work ! 🎉
|
@pheobeayo pls rebase with main so we can merge this |
|
fixed by #165 |

add projects to the backend