Skip to content

Conversation

@pheobeayo
Copy link
Contributor

add projects to the backend

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @pheobeayo !

Overall looks great 👌

But before I dig deeper I see that there are two things missing: a test file like backend/tests/profile_tests.rs that would greatly improve testing the PR and also a migration file like backend/migrations/001_initial_schema.sql in order to add projects to the database.

Thanks in advance

@pheobeayo
Copy link
Contributor Author

Thanks for the submission @pheobeayo !

Overall looks great 👌

But before I dig deeper I see that there are two things missing: a test file like backend/tests/profile_tests.rs that would greatly improve testing the PR and also a migration file like backend/migrations/001_initial_schema.sql in order to add projects to the database.

Thanks in advance

Okay, I am working on it

@pheobeayo pheobeayo requested a review from joelamouche December 9, 2025 08:19
@joelamouche
Copy link
Contributor

@pheobeayo Thanks for your work.
Please use the CI and make sure it passes before you ask for a review.
Screenshot 2025-12-09 at 10 16 30
You can click on these and you will get the logs for the errors.
Let me know if you need help reading those

@joelamouche
Copy link
Contributor

Hey @pheobeayo , happy new year!
So is this ready for review?

@pheobeayo
Copy link
Contributor Author

Hey @pheobeayo , happy new year! So is this ready for review?

Yes, it is

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work ! 🎉

@joelamouche
Copy link
Contributor

@pheobeayo pls rebase with main so we can merge this

@joelamouche joelamouche mentioned this pull request Jan 12, 2026
@joelamouche
Copy link
Contributor

fixed by #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants