forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 117
Open
Labels
MajorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facingStabilityConcerns stability of the runtimeConcerns stability of the runtime
Milestone
Description
Throwing exceptions for non critical things is not good. It stops the runtime unnecessarily. It would be better to raise asserts and return the offending code paths. This gives the runtime the chance to just move on. This is better for the user when the error is not catastrophic.
An example of an unnecessary throw is
Metadata
Metadata
Assignees
Labels
MajorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facingStabilityConcerns stability of the runtimeConcerns stability of the runtime