Skip to content

refactor(string): Implement generic startsWith, endsWith functions for C strings #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 26, 2025
Merged

refactor(string): Implement generic startsWith, endsWith functions for C strings #1898

merged 5 commits into from
Nov 26, 2025

Conversation

@slurmlord
Copy link

@slurmlord slurmlord commented Nov 23, 2025

This PR adds the string functions startsWith, startsWithNoCase, endsWith and endsWithNoCase to WWLib/stringex.h. Supports both char* and wchar_t*.

Replaced existing functions in AsciiString with calls to the corresponding new implementations:
AsciiString::startsWith
AsciiString::startsWithNoCase
AsciiString::endsWith
AsciiString::endsWithNoCase

Also added the same functions for UnicodeString.
This was split out from #1594 where the need for a endsWithNoCase for wchar_t surfaced.

@slurmlord slurmlord changed the title feat(string): Add generic string startWith/endsWith implementations feat(string): Add generic string startsWith/endsWith implementations Nov 23, 2025
@slurmlord slurmlord mentioned this pull request Nov 23, 2025
Open
@slurmlord slurmlord marked this pull request as ready for review November 23, 2025 20:17
xezon
xezon reviewed Nov 23, 2025
View reviewed changes
xezon
xezon reviewed Nov 25, 2025
View reviewed changes
xezon
xezon reviewed Nov 25, 2025
View reviewed changes
xezon
xezon approved these changes Nov 26, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Nov 26, 2025
@xezon xezon changed the title feat(string): Add generic string startsWith/endsWith implementations refactor(string): Implement generic startsWith, endsWith functions for C strings Nov 26, 2025
@xezon xezon merged commit dd51b7e into TheSuperHackers:main Nov 26, 2025
24 checks passed
@slurmlord slurmlord deleted the slurmlord/string_starts_ends_with branch November 26, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skyaero42 Skyaero42 Skyaero42 left review comments

@xezon xezon xezon approved these changes

Assignees

No one assigned

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slurmlord @xezon @Skyaero42