Skip to content

Fix Node-RED crash when uib-element receives null/undefined data #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Node-RED crash when uib-element receives null/undefined data #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
977f9a5
Initial plan
Copilot Nov 13, 2025
b3d7fdd
Initial plan for fixing Node-RED crash issue
Copilot Nov 13, 2025
8fe0ef2
Remove unrelated documentation files and update gitignore
Copilot Nov 13, 2025
23ad4ed
Fix Node-RED crash from null/undefined data in uib-element
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,4 @@ tmp/_*
docs/docs.md
docs/.config/doctest.md
docs/roadmap/.~readme.md
documentation/
8 changes: 7 additions & 1 deletion nodes/elements/elementBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ module.exports = {
*/
buildSForm: function buildSForm(node, msg, parent) {
// Make sure node.data is an object or an array - if not, force to array
if (!(Array.isArray(node.data) || node.data.constructor.name === 'Object')) node.data = [node.data]
if (!(Array.isArray(node.data) || (node.data != null && node.data.constructor != null && node.data.constructor.name === 'Object'))) node.data = [node.data]

const err = ''

Expand All @@ -381,6 +381,12 @@ module.exports = {
// Data for this row/element of the form: id, type
const frmRow = frm[rowRef]

// Check that frmRow is a valid object before processing
if (frmRow == null) {
node.warn(`🌐⚠️[uibuilder:uib-element:elementBuilder:buildSForm] Form row at index ${i} is null or undefined. Skipping.`)
return
}

// TODO Check that required properties are present

// Handle non-input inputs
Expand Down