Don't send CAP END before SASL auth is complete #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is "RECOMMENDED" in the SASL-3.1 spec, and I've found the previous behaviour to be intermittent in practice.
|
Hey, sorry I wasn't maintaining this library for awhile but I'm getting back to it now. The code as it is should wait until sasl auth finishes as the sasl handler is awaited async-irc/asyncirc/protocol.py Line 65 in 422d3e7 which will wait until the sasl handler returns before sending cap end. The intermittent behavior may be related to what I just fixed in v0.1.8 where the AUTHENTICATE payload was malformed in some circumstances |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SASL-3.1 spec recommends that
CAP ENDis not sent until SASL auth has completed. The current behaviour is to sendCAP ENDimmediately after all requested capabilities have been ACKed or NACKed.I've found the current behaviour to fail SASL auth intermittently in practice, particularly when additional capabilities are requested. This change is working much more reliably for me.
There's still arguably a race condition in the other direction now - if SASL auth completes before capability negotiation - but I think this is very unlikely to happen in practice.
(Love the library, thanks!)