Make frontend retries independently configurable - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrontendSessionMotivation
Retrying preprocessing can expose a structurally different formula, and the vtree policy appropriate for that formula is an independent choice. Applications need to vary either dimension without reconstructing the frontend workflow or relying on a method dedicated to one particular combination.
Design
FrontendSession::retryaccepts aFrontendRetryConfig. Its optionalarjun_sbvaandvtree_specfields inherit the primary configuration when omitted and apply only to that retry when present. The vtree field uses the same public specification language asRunConfig, including scoredportfolioselection and concrete constructors. Every retry begins from the same immutable simplify checkpoint and follows the same preprocessing and construction path.Validation